Skip to content

auto-cherry-pick: [v4.13] Hash sensitive data in resource logs #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2023
Merged

auto-cherry-pick: [v4.13] Hash sensitive data in resource logs #1226

merged 1 commit into from
May 21, 2023

Conversation

@redhat-qe-bot
Copy link
Contributor

@redhat-qe-bot redhat-qe-bot commented May 21, 2023

cherry-pick #1222 into v4.13

requested-by omrirh

@omrirh
Hash sensitive data in resource logs (#1222)
f0b4105 
* Omit secret data from logs

* use keys attributes hashing to hide sensitive data

* use benedict to modify resource dict

* adding keys_to_hash attribute in resource

* adding hash_log_data attribute to resource object

* using hash_log_data attribute in resource object
@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented May 21, 2023

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

  • To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
    verified label removed on each new commit push.
  • To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.
    • Support only merged PRs
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-version-

@redhat-qe-bot redhat-qe-bot requested review from myakove and rnetser May 21, 2023 11:41
@redhat-qe-bot redhat-qe-bot mentioned this pull request May 21, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove myakove merged commit a0a0e49 into v4.13 May 21, 2023
@omrirh
Copy link
Contributor

omrirh commented May 21, 2023

/verified

@myakove myakove deleted the auto-cherry-pick-omit-secret-data branch May 21, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove Awaiting requested review from myakove

@rnetser rnetser Awaiting requested review from rnetser

Assignees

No one assigned

Labels

auto-cherry-pick branch-v4.13 size/M verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redhat-qe-bot @omrirh @myakove